https://bugzilla.redhat.com/show_bug.cgi?id=996489 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@xxxxxxxxxx --- Comment #6 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to Axilleas Pipinellis from comment #3) > (In reply to Josef Stribny from comment #2) > > 1, Please remove the trailing white space: > > * after BuildRequires: rubygems-devel > > * after BuildRequires: rubygem(test-unit) > > > > Hmm, for some reason these are from gem2rpm, fixed. Yes, that is gem2rpm thing. There might be appended version, in that case there would be space between the BR and version, since there is no version, just the space remains. Fix polishing this behavior is appreciated, but I have not come up yet with any solution I would like mysel > > 3, Should the license be "X11 or MIT" (taken from the README)? Since only > > MIT is included as a standalone file and in the .gemspec, it's probably > > better to list only MIT. Maybe you can ask upstream for clarification? > > I filled an issue: https://github.com/flori/tins/issues/5 They are the same license, MIT for is the right one for Fedora. https://fedoraproject.org/wiki/Licensing:Main#Software_License_List -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zRvUfOQtX4&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review