https://bugzilla.redhat.com/show_bug.cgi?id=989359 --- Comment #2 from Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> --- (In reply to Christopher Meng from comment #1) > - Remove %defattr(-,root,root,-) Done > - %_datadir --> %{_datadir} Good catch, an oversight of my part. Fixed > - Remove commented lines. Done > - cp -a --> cp -pa Done although -a should preserve all attributes according to man cp > - %_datadir/gimp/2.0/brushes/GPS-Brushes/* and such lines in %files: > > seems you forgot to own the dir itself, change to: > > %{_datadir}/gimp/2.0/brushes/GPS-Brushes/ Done > - %description not good, suggesstion: > > GIMP Paint Studio(GPS) is a collection of brushes and accompanying tool > presets. Tool presets are a simply saved tool options, highly useful feature > of the GIMP. The goal of GPS is to provide an adequate working environment > for graphic designers and artists to begin to paint and feel comfortable > with GIMP from their first use. Done > - I see the %{url} is: > > http://gps-gimp-paint-studio.googlecode.com/files/GPS 2_0 final.zip > > should use %20 to replace the space " ". But not sure if this is my > browser's problem. rpmlint falsely claimed the above url is not found. %20 characters now replace the space " ". > - Please check if CCPL things are included. CCPL? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YaPyt9OUhC&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review