[Bug 996311] Review Request: perl-CAD-Format-STL - Read and Write STL (STereoLithography) format files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=996311

Christopher Meng <cickumqt@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cickumqt@xxxxxxxxx



--- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> ---
1. Change 0%{?rhel} to 0%{?rhel} < 6 as many old stuffs are EL5 only, even EL6
you can safely drop them.

Remove this:

find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;

As ExtUtils has solved this "bug" years ago.

Move this:

%if 0%{?rhel} in %clean:

%clean
%if 0%{?rhel}
rm -rf %{buildroot}
%endif

to

%if 0%{?rhel}
%clean
rm -rf %{buildroot}
%endif

%defattr(-,root,root,-) is also EL5 only, EL6 can drop it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=I9N6W6lW1G&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]