[Bug 995974] Review Request: libbson - BSON library for C

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=995974



--- Comment #8 from Joshua Small <technion@xxxxxxxxxxx> ---
Additional:
Your script runs autogen.sh, followed by ./configure. 
The second line of autogen.sh is "./configure", so something is redundant here.

Reading the documentation, once a tarball (stable) is developed, autogen.sh
won't be required anyway.

The application has a "make test" that should probably be used in a %check
process.

The README states:
In your source code:
#include <bson.h>

However, every header file seems to suggest you should instead #include
<bson/bson.h>. Your current -devel package places these files in
<libbson-1.0/bson.h>

On a note unrelated to packaging, new applications should not be using MD5.
Wikipedia states: http://en.wikipedia.org/wiki/MD5 "should be considered
cryptographically broken and unsuitable for further use"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eYx69CDSCg&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]