[Bug 866265] Review Request: opentrep - C++ API for parsing travel-focused requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=866265

Michael Schwendt <bugs.michael@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(bugs.michael@gmx. |
                   |net)                        |



--- Comment #9 from Michael Schwendt <bugs.michael@xxxxxxx> ---
Amazing. It's really assigned to me already, but doesn't show up anywhere in my
reviews folder.

[...]

In the build.log:

> sh: epstopdf: command not found

Many times. Adding that tool as BR doesn't seem to change anything.

  $ repoquery --whatprovides /usr/bin/epstopdf
  texlive-epstopdf-bin-3:svn18336.0-0.1.20130608_r30832.fc19.noarch
  texlive-epstopdf-bin-2:svn18336.0-22.20130427_r30134.fc19.noarch

There's a PDF in the -doc package, which contains:

  $ cat refman.pdf 
  Warning:\ the\ PDF\ reference\ manual\
(/builddir/build/BUILD/opentrep-0.5.3/doc/latex/refman.pdf)\ has\ failed\ to\
build.\ You\ can\ perform\ a\ simple\ re-build\ (make\ in\ the\ doc/latex\
sub-directory).

[...]

> opentrep-devel-0.5.3-2.fc19.x86_64.rpm 
> /bin/sh
> pkgconfig

The /bin/sh is for a shell-script:

-rwxr-xr-x  /usr/bin/opentrep-config

It contains a hardcoded libdir path and therefore is not multilib-installable.
One common way to fix it is to make the script retrieve variables from
the pkgconfig file:

  $ pkg-config --variable=libdir opentrep
  /usr/lib64

[...]

> opentrep-0.5.3-2.fc19.x86_64.rpm 
>
> -rwxr-xr-x  /usr/bin/pyopentrep

Same here (not multilib-installable) and more. It appends /usr/lib64 to
sys.path in an attempt at finding libpyopentrep, but that won't work as
expected. The needed *.so lib is stored in the optional -devel package:

  $ pyopentrep 
  Traceback (most recent call last):
  File "/usr/bin/pyopentrep", line 286, in <module>
      import libpyopentrep
  ImportError: No module named libpyopentrep

With this run-time requirement, it would be plausible to move libpyopentrep.so
into the base package, too. Even cleaner would be to store it in Python's
search path for modules, so appending to sys.path would not be needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6Nel6JdHEi&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]