[Bug 994859] Review Request: python-pygit2 - Python bindings for libgit2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=994859

Yohan Graterol <yohangraterol92@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ASSIGNED
                 CC|                            |yohangraterol92@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |yohangraterol92@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #2 from Yohan Graterol <yohangraterol92@xxxxxxxxx> ---
I sorry for the error in the last comment...

Well, I see issues in your spec...

1 - The file name should has not the same name than the package... In this case
is python-pygit2.spec not pygit2.spec. [0]
2 - You need add a BR than is necessary for the test. (unittest - python-nose)
3 - Build the doc and add in %doc macro.
4 - The SRPM file should be the same than you built with the last SPEC file
version. There differences between the spec and the spec on SRPM. 

[0] http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mCBYvZrrvY&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]