https://bugzilla.redhat.com/show_bug.cgi?id=961237 --- Comment #18 from Michael Schwendt <bugs.michael@xxxxxxx> --- $ rpmls -p sipxtapi-doc-3.3.0-5.x86_64.rpm|grep ^d drwxr-xr-x /usr/share/doc/sipxtapi/sipXcallLib drwxr-xr-x /usr/share/doc/sipxtapi/sipXmediaAdapterLib drwxr-xr-x /usr/share/doc/sipxtapi/sipXmediaLib drwxr-xr-x /usr/share/doc/sipxtapi/sipXportLib drwxr-xr-x /usr/share/doc/sipxtapi/sipXsdpLib drwxr-xr-x /usr/share/doc/sipxtapi/sipXtackLib Directory /usr/share/doc/sipxtapi is missing in this package. https://fedoraproject.org/wiki/Packaging:UnownedDirectories $ rpm -qpR sipxtapi-doc-3.3.0-5.x86_64.rpm|grep -v rpm $ > drwxr-xr-x /usr/share/doc/sipxtapi-devel-3.3.0 > -rw-r--r-- /usr/share/doc/sipxtapi-devel-3.3.0/COPYING You don't need to duplicate the license file in the -devel package, because that package depends on the base package already, which includes the same file: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing drwxr-xr-x /usr/share/doc/sipxtapi-3.3.0 -rw-r--r-- /usr/share/doc/sipxtapi-3.3.0/COPYING $ rpmls -p sipxtapi-3.3.0-5.x86_64.rpm |grep \.a$ -rwxr-xr-x /usr/lib64/sipxtapi/codecs/codec_g722.la -rwxr-xr-x /usr/lib64/sipxtapi/codecs/codec_l16.la -rwxr-xr-x /usr/lib64/sipxtapi/codecs/codec_pcmapcmu.la -rwxr-xr-x /usr/lib64/sipxtapi/codecs/codec_tones.la Does it use these libtool archives at run-time? (for example, if it uses an old libtool dlopen instead of the normal dlopen) Else delete them. It's covered in an unrelated section here: https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries So much about the test-builds. [...] > License: LGPL LGPLv2 - https://fedoraproject.org/wiki/Licensing:Main#SoftwareLicenses If you could submit a comment here in the review ticket with two valid "Spec URL:" and "SRPM URL:" fields, you could run the "fedora-review" tool and point it at this ticket. In the source code there are files with a different non-LGPL license header. What is known about that? > BuildRequires: gsm-devel Build log says: checking for libgsm >= 1.0.10... not found Codec iLBC was disabled Codec G.726 was disabled Package doesn't depend on libgsm either. > BuildRequires: xerces-c-devel Seems unused, too. Please verify. > configure: WARNING: no wx-config found - wxWidgets disabled ? > W: macro-in-comment %check "rpmlint -i …" gives a hint. Since you don't want a %check section, either delete it completely, or when commenting it out use a double-%: #%%check That disables the macro. > %defattr(-, root, root, -) Is _really_ not needed anymore since RPM 4.4. ;) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FYp0KJ8cMC&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review