https://bugzilla.redhat.com/show_bug.cgi?id=993636 --- Comment #7 from Veaceslav Mindru <mindruv@xxxxxxxxx> --- >This is an informal review as I cannot sponsor. thank you i appreciate your effort and attention >URLS: It would be appreciated if you listed a direct download URL. At present, the URL given embeds the .spec file within a website. Attempting to wget the "direct download" link requires it be escaped and then provides a file named "perl-Text-BarGraph.spec?format=raw". I will stop using sourceforge in the future, for now i am stuck with it :( > BuildRoot: %{_tmppath}/%{name}-%{version}-build >The above line is obsolete and should not be used. this slipped from me, fixed ># Text-BarGraph-1.1.tar.gz was downloaded from http://www.cpan.org/authors/id/K/ > KB/KBAUCOM/Text-BarGraph-1.1.tar.gz, LICENSE file ammended to archive >Am I correct in the understanding that you downloaded from the above URL, then altered the tarball with a LICENSE file? This means there is no programmatic method of downloading the upstream source and creating the one you used. >A more correct method would be to define Source1: as containing the LICENSE file, then Source0: could be a proper URL. fixed Source0 , Source1 URL to LICENSE file >#However, this leads me to the concern that you have listed license as: >#License: GPL+ or Artistic >#Everything in the actual source suggests it is using Artistic Clarified. changed to License: Artistic Clarified >find . -type f -print0 | xargs -0 chmod 644 >I'm unsure what value the above line adds to the .spec file. Fixed >The package fails to actually build in koji which should be a clear blocker: >http://kojipkgs.fedoraproject.org//work/tasks/7717/5787717/build.log previously was building only for root user, fixed. >What I'm seeing is that "make pure_install" doesn't pay attention to the build root. >DESTDIR=%{buildroot} might fix it depending on the Makefile. You may be able >to remove this line altogether as you appear to have used the "install" command to copy appropriate files. fixed Will continue with other review recommendations -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Tprl3wdCCQ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review