[Bug 961237] Review Request: sipxtapi - SIP stack and real-time media framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=961237



--- Comment #10 from Michael Schwendt <bugs.michael@xxxxxxx> ---
There's more without looking too long...


> Requires: openssl >= 0.9.8

https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires
and %{?_isa} would be missing anyway.


> BuildRequires: cppunit-devel

There are unit tests available? Any of them suitable for a %check section?


> Requires: %{name}-libs%{?_isa} = %{version}-%{release}

-libs is a wrong leftover here.


> %package apidoc

Typically, we call them -doc not -apidoc:
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation


> %{_datarootdir}

The package must not own /usr/share.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kbZjiMmdtG&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]