[Bug 987457] Review Request: rubygem-fast_xs - Provides C extensions for escaping text

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=987457

Josef Stribny <jstribny@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Josef Stribny <jstribny@xxxxxxxxxx> ---
Please fix:

* Escape macros in comments
  rubygem-fast_xs.spec:57: W: macro-in-comment %gem_dir

* Description of -doc package should end up with a dot and the description of
the main package could a little more formatted (2 line breaks after a
paragraph).

Otherwise the spec looks good, it builds, installs & works. Since the issues
are minor and could be fixed before pushing I am APPROVING this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s9SF6tW85V&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]