https://bugzilla.redhat.com/show_bug.cgi?id=961237 --- Comment #5 from Christopher Meng <cickumqt@xxxxxxxxx> --- Yes, because you give us a template, we can also refuse to review your package, who knows exactly the content is. First glimpse at spec: 1. Drop Vendor: SIPfoundry Packager: Daniel Pocock <daniel@xxxxxxxxxxxxx> 2. It's better to add --disable-static to the configure. 3. Why providing a libs subpackage? Can't it be merged into main package? 4. I don't hope you include "test" in the version field. 5. I'm sorry in the past years I never use Group tag, and you use Group: Development/Libraries in 2 different subpackages, I think it's not perfect, recommend dropping it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lFYoH2AGTC&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review