[Bug 994308] Review Request: perl-Proc-Queue - Limit the number of child processes running

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=994308



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:-

+ Package builds fine in mock (f20)

- rpmlint on generated rpms gave
perl-Proc-Queue.noarch: W: spelling-error %description -l en_US parallelise ->
parallelism, paralleled, parallel
perl-Proc-Queue.noarch: W: spelling-error %description -l en_US waitpid ->
wapiti
perl-Proc-Queue.noarch: W: file-not-utf8
/usr/share/doc/perl-Proc-Queue-1.23/README
perl-Proc-Queue.src: W: spelling-error %description -l en_US parallelise ->
parallelism, paralleled, parallel
perl-Proc-Queue.src: W: spelling-error %description -l en_US waitpid -> wapiti
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

+ Source verified with upstream as (sha256sum)
upstream tarball : 
3aca4e2a46b5c01498a446607a73f2c9121118a58cd670b3df285b6bca0d3f1c
srpm tarabll : 3aca4e2a46b5c01498a446607a73f2c9121118a58cd670b3df285b6bca0d3f1c

+ License is valid and include in source file.

+ make test gave
All tests successful.
Files=2, Tests=10, 21 wallclock secs ( 0.01 usr  0.00 sys +  0.04 cusr  0.04
csys =  0.09 CPU)

+ Package perl-Proc-Queue-1.23-1.fc20.noarch
Provides: perl(Proc::Queue) = 1.23 perl-Proc-Queue = 1.23-1.fc20
Requires: perl >= 0:5.006 perl(Carp) perl(Errno) perl(Exporter) perl(POSIX)
perl(constant) perl(strict)


Suggestions:
1) rpmlint compains for README file as not utf8. Fix it in %prep as
iconv --from=ISO-8859-1 --to=UTF-8 README > README.new && \
touch -r README README.new && \
mv README.new README

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yGHafns2Hz&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]