https://bugzilla.redhat.com/show_bug.cgi?id=804125 --- Comment #16 from Gianluca Sforna <giallu@xxxxxxxxx> --- (In reply to Christopher Meng from comment #14) > Also %{docdir}/README should be changed to %{_pkgdocdir}/README > done > Then, cmake has %cmake macro, you should rpm -E %cmake and find if the macro > can replace 6 lines of options. done > > Next, Remove rm -rf %{buildroot} in %install done > > Last, are these %{_libdir}/*.cmake needed? they are useful if you want to build programs using the rdkit libraries. As the comment says, I am not sure that is a good place for them but inherited it from upstream so I left them there for now. Also, I updated the package to latest upstream release, which is supposed to work with pillow. A rawhide mock build passes so I assume we are ok. http://giallu.fedorapeople.org/rdkit.spec http://giallu.fedorapeople.org/rdkit-2013.06.1-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ubCDBrj2Wt&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review