[Bug 843678] Review Request: sugar-castle - A game of discovery and strategy inspired by the Adventure games of the 70s

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=843678

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #10 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
reviewing above srpm

1) use BR:python2-devel

2) remove follwing line in spec
rm -rf  {buildroot}

3)Don't use any backslash between %{buildroot} and %{_prefix}, so your %install
should look like
%{__python} ./setup.py install --prefix=%{buildroot}%{_prefix}

4) This package archive is really bad in file permissions. You can use
following %prep which should address most of rpmlint issues
%setup -q -n Castle.activity
chmod -x *.py
chmod -x data/*.dat
chmod -x  activity/activity.svg
chmod +x setup.py Castle.py

sed -i "s|\r||g" Castle.py
sed -i "s|\r||g" activity/activity.svg

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rivnQgWAOo&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]