https://bugzilla.redhat.com/show_bug.cgi?id=988728 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |hdegoede@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |hdegoede@xxxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Hans de Goede <hdegoede@xxxxxxxxxx> --- Good: -------- - rpmlint checks return: chinese-calendar.x86_64: W: no-documentation chinese-calendar.x86_64: W: no-manual-page-for-binary chinese-calendar These can safely be ignored - package meets naming guidelines - package meets packaging guidelines - license (GPLv3) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file Should fix: --------------- - rpmlint checks return: chinese-calendar.x86_64: W: spelling-error %description -l en_US useing -> using, unseeing, segueing chinese-calendar.x86_64: W: desktopfile-without-binary /usr/share/applications/chinese-calendar.desktop /usr/bin/chinese-calendar Please fix the spelling error in %description. The second warning is caused by the .desktop file containing a full-path ( /usr/bin/chinese-calendar) rather then just chinese-calender, would be nice to also fix this. -the spec should run desktop-file-validate on the installed .desktop file (and BuildRequires desktop-file-utils for this). No blockers, approved! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aBjFQXmeHi&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review