[Bug 232612] Review Request: perl-Class-Observable - Allow other classes and objects to respond to events in yours

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Class-Observable - Allow other classes and objects to respond to events in yours


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232612





------- Additional Comments From cweyl@xxxxxxxxxxxxxxx  2007-03-16 23:06 EST -------
The construct:

%if "%fedora" >= "7"
BuildRequires:  perl-devel
%endif

Is highly non-portable, and indeed, causes the package to fail to rebuild even
on Fedora machines if %fedora hasn't been defined somewhere.  With the
still-being-worked-through perl/perl-devel split, the preferred (well, to me
at least) and, more importantly, portable way of pulling in perl-devel is to
have a buildrequires on the module used to handle the build.  In this case,
we're in a standard Makefile.PL situation, so adding a buildrequires against
perl(ExtUtils::MakeMaker) will be both portable and cause perl-devel to be
pulled in.

Replace the conditional with a BuildRequires: perl(ExtUtils::MakeMaker) and
I'll approve the package.


+ source files match upstream:
a4fe8e71f0082e51d5d97da865b6a708  Class-Observable-1.04.tar.gz
a4fe8e71f0082e51d5d97da865b6a708  ../Class-Observable-1.04.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible.  License text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package installs properly
O noarch -- no debuginfo package
+ rpmlint is silent.
+ final provides and requires are sane:
== provides
perl(Class::Observable)
perl-Class-Observable = 1.04-1.fc6
== requires
perl(:MODULE_COMPAT_5.8.8)
perl(Class::ISA)
perl(Scalar::Util)
perl(strict)
+ %check is present and all tests pass:
All tests successful.
Files=2, Tests=39,  0 wallclock secs ( 0.10 cusr +  0.04 csys =  0.14 CPU)
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]