[Bug 990932] Review Request: erlang-riaknostic - A diagnostic tool for Riak installations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=990932



--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Hi Peter,
I found some small issues:

rpmlint output:

erlang-riaknostic.src: W: spelling-error %description -l en_US riak → false
positive
erlang-riaknostic.src: W: invalid-url Source0:
basho-riaknostic-v1.1.0-0-g8cfb08e.tar.gz → You can use github link like
https://github.com/basho/riaknostic/archive/v1.1.0.tar.gz, which should give
the same file.

Also, there's a new upstream release v1.2.0.

erlang-riaknostic.x86_64: W: spelling-error %description -l en_US riak → false
positive

erlang-riaknostic.x86_64: E: no-binary
erlang-riaknostic.x86_64: W: only-non-binary-in-usr-lib
→ both are normal for Erlang-related packages

Is the package really usable without riak-admin? The documentation mentions
that it can be run standalone for testing purposes... I don't know almost
anything about riak, so I'm guessing here, but I think that it should have
Requires:riak.

Also, maybe the description could be updated to say "is a plugin for
riak-admin" instead of "is integrated with ...", just to be more direct.

So, the only two non-suggestion things are Source and the new upstream release.
I'll do a point-by-point review when that is fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GHADSKvupg&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]