https://bugzilla.redhat.com/show_bug.cgi?id=851793 Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> --- $ rpmlint mingw-fftw.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint mingw-fftw-3.3.3-2.fc19.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint mingw32-fftw-3.3.3-2.fc19.noarch.rpm mingw32-fftw-static-3.3.3-2.fc19.noarch.rpm mingw64-fftw-3.3.3-2.fc19.noarch.rpm mingw64-fftw-static-3.3.3-2.fc19.noarch.rpm mingw32-fftw-static.noarch: W: no-documentation mingw64-fftw-static.noarch: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpm --query --requires mingw32-fftw rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw32-crt mingw32-filesystem >= 95 mingw32(kernel32.dll) mingw32(libgcc_s_sjlj-1.dll) mingw32(msvcrt.dll) mingw32-pkg-config rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw64-fftw rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw64-crt mingw64-filesystem >= 95 mingw64(kernel32.dll) mingw64(msvcrt.dll) mingw64-pkg-config rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw32-fftw-static rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw64-fftw-static rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --provides mingw32-fftw mingw32-fftw = 3.3.3-2.fc19 mingw32(libfftw3-3.dll) mingw32(libfftw3f-3.dll) mingw32(libfftw3l-3.dll) $ rpm --query --provides mingw64-fftw mingw64-fftw = 3.3.3-2.fc19 mingw64(libfftw3-3.dll) mingw64(libfftw3f-3.dll) mingw64(libfftw3l-3.dll) $ rpm --query --provides mingw32-fftw-static mingw32-fftw-static = 3.3.3-2.fc19 $ rpm --query --provides mingw64-fftw-static mingw64-fftw-static = 3.3.3-2.fc19 $ wget --quiet http://www.fftw.org/fftw-3.3.3.tar.gz -O - | md5sum 0a05ca9c7b3bfddc8278e7c40791a1c2 - $ md5sum fftw-3.3.3.tar.gz 0a05ca9c7b3bfddc8278e7c40791a1c2 fftw-3.3.3.tar.gz + OK ! Needs to be looked into / Not applicable [+] Compliant with generic Fedora Packaging Guidelines [+] Source package name is prefixed with 'mingw-' [+] Spec file starts with %{?mingw_package_header} [!] BuildRequires: mingw32-filesystem >= 95 is in the .spec file [!] BuildRequires: mingw64-filesystem >= 95 is in the .spec file [+] Spec file contains %package sections for both mingw32 and mingw64 packages [+] Binary mingw32 and mingw64 packages are noarch [+] Spec file contains %{?mingw_debug_package} after the %description section [+] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4 to configure the package [+] Uses the macro %mingw_make to build the package [+] Uses the macro %mingw_make to install the package [/] If package contains translations, the %mingw_find_lang macro must be used [+] No binary package named mingw-$pkgname is generated [+] Libtool .la files are not bundled [+] .def files are not bundled [+] Man pages which duplicate native package are not bundled [+] Info files which duplicate native package are not bundled [+] Provides of the binary mingw32 and mingw64 packages are equal [!] Requires of the binary mingw32 and mingw64 packages are equal The mingw32 package seems to depend on libgcc_s_sjlj-1.dll while the mingw64 package doesn't. I've also seen this on various other packages so we can ignore this for now The BuildRequires: mingw32-filesystem mingw64-filesystem should be versioned (to >= 95). Please fix this before importing this package in Fedora ================================================ The package mingw-fftw is APPROVED by epienbro ================================================ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TeiV2TVEY3&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review