[Bug 988310] Review Request: rubygem-mobileesp_converted - Provides device type detection based on HTTP request headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=988310

Josef Stribny <jstribny@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+



--- Comment #4 from Josef Stribny <jstribny@xxxxxxxxxx> ---
Thanks, it's looks good now.

I would personally move removal of bundler dep to %check, where it makes
clearer why are you doing so. Please consider before pushing.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hUUWrzVFql&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]