https://bugzilla.redhat.com/show_bug.cgi?id=988818 Josef Stribny <jstribny@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #2 from Josef Stribny <jstribny@xxxxxxxxxx> --- * Use %%gem_dir to escape macro in comment rubygem-xmlhash.spec:50: W: macro-in-comment %gem_dir * Adjust summary rubygem-xmlhash.src: E: summary-too-long C A small C module that wraps libxml2's xmlreader to parse a XML string into a ruby hash * Move %doc %{gem_instdir}/README.txt to the main package since it contains licensing information, ideally you could ask upstream to provide a separate license file. * I believe that /ext files used to build the extension could be probably put into -doc subpackage for clarification. * Run the test suite with: testrb -Ilib test/test_xmlhash.rb so the library is properly loaded and tests run. Other than that I have no complains. It builds, installs and works in mock. Please fix the issues above. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XCTBpIULh2&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review