[Bug 988789] Review Request: rubygem-hoptoad_notifier - Send your application errors to our hosted service and reclaim your inbox

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=988789



--- Comment #2 from Josef Stribny <jstribny@xxxxxxxxxx> ---
Testing this package is difficult since it's built against Rails 2 and
automatic tests cannot be run easily. Since you expressed that there are people
using it with Rails 4.0, it can be used in non-Rails apps as well and since I
didn't encounter any errors when playing with it I believe this package can get
to Fedora, although it might be difficult to keep it in shape in future.
Because you want to maintain it despite the support from upstream, I have no
objections.

Please fix the following:

* Carry the license file with the package
  Move %doc %{gem_instdir}/MIT-LICENSE to main package

* Description of the doc sub-package should end up with a dot.

Otherwise the package builds and installs with the upcoming Rails 4.0 update
and spec seems to be fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YGlLKBNlog&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]