Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mugshot - Companion software for mugshot.org https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212003 ------- Additional Comments From green@xxxxxxxxxx 2007-03-16 20:07 EST ------- Ok, here are my notes. See the three lines starting with "X". I would accept this package once these minor issues are addressed. * package meets and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. * License text included in package. * source files match upstream ef0f337dbbe919e0a67deac9591863ce /usr/src/redhat/SOURCES/mugshot-1.1.38.tar.gz ef0f337dbbe919e0a67deac9591863ce mugshot-1.1.38.tar.gz * latest version is being packaged. * BuildRequires are proper. * package builds in mock. X rpmlint has two complaints. See comments #14, #15 and #16. I think we can ignore the config file issue, but it would be good to clean up with .la and .a files. * final provides and requires are sane: libhippofirefox.so mugshot = 1.1.38-1 == GConf2 gtk2 libICE.so.6 libORBit-2.so.0 libSM.so.6 libX11.so.6 libXss.so.1 libart_lgpl_2.so.2 libatk-1.0.so.0 libbonobo-2.so.0 libbonobo-activation.so.4 libbonoboui-2.so.0 libcairo.so.2 libcurl.so.3 libdbus-1.so.3 libdbus-glib-1.so.2 libdl.so.2 libgconf-2.so.4 libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgnome-2.so.0 libgnome-desktop-2.so.2 libgnome-keyring.so.0 libgnomecanvas-2.so.0 libgnomeui-2.so.0 libgnomevfs-2.so.0 libgobject-2.0.so.0 libgthread-2.0.so.0 libgtk-x11-2.0.so.0 libjpeg.so.62 libloudmouth-1.so.0 libm.so.6 libnspr4.so libpango-1.0.so.0 libpangocairo-1.0.so.0 libpangoft2-1.0.so.0 libpcre.so.0 libplc4.so libplds4.so libpopt.so.0 librt.so.1 libstartup-notification-1.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) libxml2.so.2 loudmouth >= 1.0.3-3 * shared library is present, but no ldconfig required (firefox plugin). * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is not present * scriptlets OK * code, not content. * upstream includes no docs. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. X includes libtool .la droppings. This must be removed. X .desktop looks fine, however... The packaging guidelines say that .desktop files MUST be installed with desktop-file-install. mugshot's Makefile simply copies the file instead. If we want to abide by the rules 100%, perhaps we should desktop-file-install the .desktop file again. Alternatively, we could run desktop-file-validate on the Makefile installed .desktop file as a sanity check and fail the build if necessary. What do you think? See http://fedoraproject.org/wiki/Packaging/Guidelines#desktop * not a web app. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review