https://bugzilla.redhat.com/show_bug.cgi?id=967333 Josef Stribny <jstribny@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #5 from Josef Stribny <jstribny@xxxxxxxxxx> --- Looks good now. 2 minor things that would be nice to do: * Description of -doc sub-package should end with a dot "." as a normal English sentence, please add it. * Be more specific when listing files %doc %{gem_instdir}/*.gemspec > %doc %{gem_instdir}/%{gem_name}.gemspec Since those are not blockers I APPROVE this package. Please fix above mentioned issues before pushing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4Ot589E45e&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review