https://bugzilla.redhat.com/show_bug.cgi?id=870853 --- Comment #7 from Davide Benini <dbenini@xxxxxxxxx> --- (In reply to Christopher Meng from comment #5) Hi Christopher, > 1. Why not nameing it safehaven but haven? To be aligned with upstream name. > 2. %define _hardened_build 1 I've made the suggested change to the spec file: Spec URL: http://www.dbenini.com/haven/fedora/haven.spec SRPM URL: http://www.dbenini.com/haven/fedora/haven-0.0.2-7.fc19.src.rpm * Koji scratch build info: https://koji.fedoraproject.org/koji/taskinfo?taskID=5776199 > 3. Can you ask upstream to avoid using > > %global _configure ../../configure > mkdir -p build/standard build/gtkgui build/full > cd build/standard > %configure --disable-ext2fs --disable-gmime --without-postgresql? > > I think this is not cmake, why should we burden ourselves? I will get in touch with upstream about this. > 4. I think you should add requires of main package for all subpackages. > > 5. Once you've done the 4, you should remove subpackages' There is no main package, see previous comments. > 6. You shouldn't create a new tarball when the download URL is available. Could you please elaborate this one? Thanks -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=buLrGQrLSd&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review