https://bugzilla.redhat.com/show_bug.cgi?id=989143 Ken Dreyer <ktdreyer@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ktdreyer@xxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |ktdreyer@xxxxxxxxxxxx --- Comment #1 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> --- Thank you for packaging this! Here are two things I noticed mid-review: My preference would be to remove bundler with sed during %prep instead of %check, so that we ship the modified helper.rb file that we actually used during testing. It's ok to set LANG during %check, but I recommend filing a bug upstream on this. It's not valid for upstream to assume that LANG is set to anything, or en_US.utf-8 in particular. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Tn2gulSl2t&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review