https://bugzilla.redhat.com/show_bug.cgi?id=991531 Joshua Small <technion@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |technion@xxxxxxxxxxx --- Comment #3 from Joshua Small <technion@xxxxxxxxxxx> --- I am not a sponsor but would like to offer an informal review. URLs: Both of these URLs given linked to website related to the SPEC and SRPM, however, nothing we would easily use a wget on. It would assist reviewers if a direct link could be given. rpmlint: For maximum effect, this should be run against your spec file, the SRPM and RPM files. Ignoring spelling warnings, it presents these complaints: sartgraph.src: W: no-version-in-last-changelog sartgraph.noarch: W: no-version-in-last-changelog sartgraph.noarch: W: no-manual-page-for-binary sartgraph I believe updating your spec file with a version number as per the guidelines document would solve two of these complaints: https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs It appears that the only documentation is in the form of the license, and you probably need at least a basic document added as a %doc. I appreciate that as a Perl script you pretty much "just run it", but you should say so. I've run a koji build for you, which you can see here: http://koji.fedoraproject.org/koji/taskinfo?taskID=5712574 [fedora@ip-172-31-20-108 noarch]$ rpmls sartgraph-0.2-2.fc19.noarch.rpm -rwxr-xr-x /usr/bin/sartgraph drwxr-xr-x /usr/share/doc/sartgraph-0.2 -rw-r--r-- /usr/share/doc/sartgraph-0.2/LICENSE Permissions look correct. There are no libraries or special files in this package and thus it avoids many pitfalls by default. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TTiVO5B8rO&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review