https://bugzilla.redhat.com/show_bug.cgi?id=991314 --- Comment #6 from Joshua Small <technion@xxxxxxxxxxx> --- Again, thank you for the review. I've used the summary and description you've suggested in my updated spec file with this. I've also configured it to use the %{optflag} macro, which I've brought back to what I was trying to achieve with the original CLFAGS by adding %global _hardened_build 1. Based on the build output it appears to be using it. Regarding the permissions/chmod issue, I saw this more as an upstream problem (make install should have managed this) and fixed it there in v1.13. Note, I haven't actually tagged v1.13 at the official distribution yet. I really don't want to end up with 49 "stable releases" due to troubleshooting on the packaging. The commit that the SRPM was created from will get this tag the moment I hear we look ready to go. I'm not sure what to make of the SONAME issue. I fixed the issues above, then ran your commands and the soname seems to be there: [fedora@ip-172-31-20-108 SPECS]$ rpm -qp --provides /home/fedora/rpmbuild/RPMS/x86_64/libscrypt-1.13-1.fc19.x86_64.rpm libscrypt = 1.13-1.fc19 libscrypt(x86-64) = 1.13-1.fc19 libscrypt.so.0()(64bit) libscrypt.so.0(libscrypt)(64bit) I must admit I don't fully understand this issue so any advice here would be appreciated. Likewise, the debuginfo seems full of files now: [fedora@ip-172-31-20-108 SPECS]$ rpmls -p /home/fedora/rpmbuild/RPMS/x86_64/libscrypt-debuginfo-1.13-1.fc19.x86_64.rpm rpm: no arguments given for query drwxr-xr-x /usr/lib/debug drwxr-xr-x /usr/lib/debug/.build-id drwxr-xr-x /usr/lib/debug/.build-id/97 ... In evaluating rpmlint: [fedora@ip-172-31-20-108 rpmbuild]$ rpmlint --verbose ./SPECS/libscrypt.spec ./SRPMS/libscrypt-1.13-1.fc19.src.rpm ./RPMS/x86_64/* Numerous spelling warnings: Spelling is correct, scrypt just happens to look like "script" or "crypt" libscrypt.src: W: invalid-url Source0: https://github.com/technion/libscrypt/archive/v1.13.tar.gz HTTP Error 404: Not Found As above, the second it looks like we've resolved everything else I'll tag 1.13 and this error will go away. W: no-documentation I've made some changed to the spec file and believe this issue is resolved for the main rpm. -devel also claims to have "no documentation", but the README.md covers both elements of the RPM and such I don't consider this an issue. Yet another SRPM update: http://www.lolware.net/libscrypt-1.13-1.fc19.src.rpm Updated spec file is in original location. New koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5699750 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IB1b54I2lz&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review