https://bugzilla.redhat.com/show_bug.cgi?id=984321 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Informal review: Description isn't very useful, unless one knows what "Powerline" is. I don't, so it doesn't tell me (a) what the package is for (b) what can I use it with (some specific shell or all shells, some specific terminal emulator or all emulators, tty?). The font that is included in the package: is it only useful for this utility, or can it be used by others? If so, maybe it should be split out to a separate package. There's a bunch of tests in upstream. Can they be run during package build? powerline.spec:48: E: hardcoded-library-path in /usr/lib/* → %{_libdir}? powerline.spec: W: invalid-url → gives 404 powerline.noarch: W: conffile-without-noreplace-flag /etc/fonts/conf.d/10-powerline-symbols.conf powerline.noarch: W: no-manual-page-for-binary powerline powerline.noarch: W: no-manual-page-for-binary powerline-lint It'd be nice to provide some examples of use. I tried 'powerline 123 left' and got the following traceback: 2013-08-02 16:56:54,536:ERROR:123:Failed to create renderer: '123' Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/powerline/__init__.py", line 361, in update_renderer self.create_renderer(**create_renderer_kwargs) File "/usr/lib/python2.7/site-packages/powerline/__init__.py", line 203, in create_renderer self.ext_config = config['ext'][self.ext] KeyError: '123' Traceback (most recent call last): File "/usr/bin/powerline", line 24, in <module> segment_info=segment_info, File "/usr/lib/python2.7/site-packages/powerline/__init__.py", line 372, in render return self.renderer.render(*args, **kwargs) AttributeError: 'ShellPowerline' object has no attribute 'renderer' ^^^^^^^ this looks like an upstream bug. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6qtRfo8Xlt&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review