https://bugzilla.redhat.com/show_bug.cgi?id=991221 --- Comment #3 from Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > Informal review (I'm not a packager): > > Looks like a useful tool! > > The license is "BSD" in Fedora [1] (aka "New BSD License", "BSD-new", etc.). I'm used to the FreeBSD license (mainly because I don't have any trademark to protect...). I saw "Intel" in the middle of the file and didn't think further... Thanks for review. > The package is correct and follows all packaging guidelines, afaict. > Builds fine [2]. > I was wondering if the spec should explicitely exclude non-intel architectures: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Architecture_Support > [1] > https://fedoraproject.org/wiki/Licensing: > Main?rd=Licensing#Software_License_List > [2] http://koji.fedoraproject.org/koji/taskinfo?taskID=5693645 Spec URL: https://bitbucket.org/dridi/fedora_packages/downloads/numatop.spec SRPM URL: https://bitbucket.org/dridi/fedora_packages/downloads/numatop-1.0.1-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=a6DuL29KhV&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review