https://bugzilla.redhat.com/show_bug.cgi?id=991314 --- Comment #4 from Michael Schwendt <bugs.michael@xxxxxxx> --- * Run rpmlint (or rpmlint -I for more helpful output) on the src.rpm and all built rpms. Feel free to ignore obvious false positives in the report, but fix anything else. Preferably add a comment here about whether/when you think what rpmlint reports is correct or incorrect. > Summary: Linux scrypt shared library Imagine all packages added "Linux" at the beginning of the summary. That's really superfluous. Mentioning that it's a "shared" lib currently is also uninteresting, since Fedora focuses on shared libs. However, you could spend a few more words on summing up what's included in the package. You don't need to restrict yourself to just 2-3 words, e.g. the first sentence from the %description sounds good: Summary: Library that implements the secure password hashing function "scrypt" Or more generic: Summary: Password hash crypto library > %description > A shared library that implements the secure password hashing > function "scrypt". Not really a full sentence. Better: %description This is a library that implements the secure password hashing function "scrypt". * In the build.log: > + make -j5 > gcc -O2 -Wall -g -D_FORTIFY_SOURCE=2 -fstack-protector -fPIC -c -o > crypto_scrypt-nosse.o crypto_scrypt-nosse.c It doesn't use Fedora's compiler %{optflags} yet: https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags > -Wl,-soname,libscrypt.so.0 Something's wrong there. The package (your koji build) doesn't provide the SONAME yet: $ rpm -qp --provides libscrypt-1.12-1.fc19.x86_64.rpm libscrypt = 1.12-1.fc19 libscrypt(x86-64) = 1.12-1.fc19 That's a major blocker. The -devel package depends on it, but it's not provided. The -devel package would not even install. > $ rpmls -p libscrypt-debuginfo-1.12-1.fc19.x86_64.rpm > $ The -debuginfo package is empty and useless. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EEAqwujRqp&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review