[Bug 985753] Review Request: dfuzzer - Fuzzer for processes connected to D-Bus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=985753



--- Comment #8 from Michael Schwendt <bugs.michael@xxxxxxx> ---
Run rpmlint (or rpmlint -I for more helpful output) on the src.rpm and all
built rpms. Feel free to ignore obvious false positives in the report, but fix
anything else. Preferably add a comment here about whether/when you think what
rpmlint reports is correct or incorrect.


> Summary: Package does fuzz testing of processes connected to D-Bus

Imagine every %summary started with "Package does ...". ;-) Not only would it
look strange, it would be less concise than it could be:

  Summary: Fuzz testing processes communicating through D-Bus
  Summary: D-Bus fuzz testing tool

https://fedoraproject.org/wiki/Examples_of_good_package_summaries


> install -pm 0644 man/dfuzzer.1.gz %{buildroot}%{_mandir}/man1/dfuzzer.1.gz

Please prefer the uncompressed manual page, because rpmbuild compresses man
pages on-the-fly.

> %{_mandir}/man1/dfuzzer.1.gz

%{_mandir}/man1/dfuzzer.1*  is what many reviewers recommend, because it allows
for changed/customised/disabled compression of manual pages.


> warning: bogus date in %changelog: Tue Jul 29 2013 Matus Marhefka <mmarhefk@xxxxxxxxxx> 1.0-1

$ date -d 'Tue Jul 29 2013'
Mon 29 Jul 00:00:00 CEST 2013

or Tue Jul 30


> + make doc
> doxygen doxyfile
> make: doxygen: Command not found
> make: *** [doc] Error 127

BuildRequires: doxygen

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ICHYL1JaOz&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]