https://bugzilla.redhat.com/show_bug.cgi?id=991314 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@xxxxxxxxx --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- Hi, I think you can add your name in Bugzilla ;) This is an informal review: 0. I think you can improve the summary of this library, not just "scrypt() library". 1. Version field has a "a", is it an Alpha release? If so, see: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Version_Tag As rpmlint said: libscrypt.i686: W: incoherent-version-in-changelog 1.1 ['1.1a-1.fc20', '1.1a-1'] 2. Remove rm -rf $RPM_BUILD_ROOT in %install section. 3. Change PREFIX=/usr to PREFIX=%{_prefix} 4. We don't recommend shipping static libraries, see: So please change find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';' to find $RPM_BUILD_ROOT -name '*.*a' -exec rm -f {} ';' -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PpiyuBQw7E&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review