https://bugzilla.redhat.com/show_bug.cgi?id=988545 --- Comment #13 from Timothy St. Clair <tstclair@xxxxxxxxxx> --- (In reply to Ralf Corsepius from comment #11) > Some remarks: > > 1. The package is incomplete or lacks a dep: > > stout/gtest.hpp accesses a file, which does not exist: > include/stout/gtest.hpp:#include <gtest/gtest.h> in the spec and the auto-tools there should be a call out for gtest-devel which certain does contain the header file <gtest/gtest.h> > > 2. C++-header-only packages should exercise test suites, when a package > provides such. This package provides a testsuite (examples), unfortunately > these are nonbuildable. > We can open a ticket upstream around *this. > > 3. The cpp-define usage of this package raises doubts on this package's code > quality: > > E.g. > a) Some header guards are non-"package"-prefixed: > __NOTHING_HPP__ include/stout/nothing.hpp > __PROCESS_PREPROCESSOR_HPP__ include/stout/preprocessor.hpp > __PROC_HPP__ include/stout/proc.hpp > > All other header-guards are package-prefixed (They use: "__STOUT_"*) > > b) Some of the defines being used are likely to clash with other defines, > e.g. > CAT, REPEAT etc. in include/stout/preprocessor.hpp > > c) The package relies on autoconf defines in external headers: > include/stout/gzip.hpp:#ifdef HAVE_LIBZ > include/stout/net.hpp:#ifdef HAVE_LIBCURL > > This violates the autoconf working principles and needs to be fixed (REVIEW > BLOCKER) We should definitely fix #3, I will try to get an update shortly. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DQYNT8XVdu&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review