https://bugzilla.redhat.com/show_bug.cgi?id=658754 --- Comment #54 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- Ok, this package is rather big so i definitely missed something else. Here are the issues I found so far: * First of all you must use %configure instead of ./configure. It sets all necessary variables (libdir, etc). if you'e insisting on using ./configure then please explain this. * rpmling throws a lot of warnings about unstripped-binary-or-object. I advise you to fix ./configure usage as mentioned above and repeat building in Koji. * Requires(post): systemd, Requires(preun): systemd, Requires(postun): systemd - these should be dropped. The only viable target w/o systemd is EPEL 6 (I personally don't recommend adding new packages into EPEL 5). * "Requires: %{name}%{?_isa} = %{cubrid_version}.%{build_version}" is not enough. You should require %{release} as well. E.g. proper form is "Requires: %{name}%{?_isa} = %{cubrid_version}.%{build_version}-%{release}" I think I've got your idea here, however sometimes cubrill will be rebuilt by the robots, and they will blindly increase %{release} number. * demodb has "%defattr(-,cubrid,cubrid,-)". Is it really necessary - to lock out demo (e.g. samples, publicly available in Internet) from a user which has shell access to the computer? I suppose this is a leftover and should be simply removed. Otherwise please explain this. * Regarding "%defattr(-,cubrid,cubrid,-)" in the main %files section. I suppose it should be "%defattr(-,%{cubrid_user},%{cubrid_user},-)". Just for better consistency with other places where you setting permissions. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Wn1gu1jt0D&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review