[Bug 990569] Review Request: rubygem-rails-observers - ActiveModel::Observer, ActiveRecord::Observer and ActionController::Caching::Sweeper extracted from Rails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=990569



--- Comment #2 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
text in %description should end with dot.

>sed -i '1d' Rakefile
I would prefer:
sed -i '1|#!/usr/bin/env|d' Rakefile
which is just safer in case content of Rakefile will change in future versions.

I prefer that README is in main package and not in -doc subpackage. As it give
you very brief guidance how to use that package and does not force user to
install -doc. But that is just my personal preference. Feel free to ignore me
in this point.

Just from quick glance. More deeply review will follow soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VTaNvtAkcO&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]