[Bug 990805] Review Request: winswitch - A tool which allows you to display running applications on other computers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=990805

T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tchollingsworth@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |tchollingsworth@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> ---
> %files
> %{_datadir}/Thunar/sendto/thunar-%{name}.desktop

This directory is not owned by this package or by any Requires.

Since Thunar is probably not required to use this package, you probably want to
co-own the directory with Thunar.

For more information, see:
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function

> %{_libdir}/nautilus/extensions-2.0/python/nautilus_%{name}.*

This directory is also not owned by this package or by any Requires.

Since nautilus is probably not required to use this package, you probably want
to co-own this directory as well.

This package fails to build due to issues with the %files list:

> RPM build errors:
>     File not found by glob: /home/tc/rpmbuild/BUILDROOT/winswitch-0.12.19-1.fc19.x86_64/usr/lib64/nautilus/extensions-2.0/python/nautilus_winswitch.*
>     File not found: /home/tc/rpmbuild/BUILDROOT/winswitch-0.12.19-1.fc19.x86_64/usr/lib64/python2.7/site-packages/winswitch-0.12.19-py2.7.egg-info
>     File not found: /home/tc/rpmbuild/BUILDROOT/winswitch-0.12.19-1.fc19.x86_64/usr/lib64/python2.7/site-packages/winswitch

Looks like you need to use %{python_sitelib} instead of %{python_sitearch} for
the second two.  I'm not sure what the deal is with nautilus.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3MZ7Ry84W2&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]