[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=927374



--- Comment #13 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
(In reply to Troy Dawson from comment #8)
> -- Since we are building with the libgit2-devel rpm installed we just need
> to remove the vendor directory at the end.  See comment #2.

Troy, this is not a good idea. I suspect that rugged is build and staticaly
linked against vendored libgit2. These are parts of build logs that suggest
that:

checking for gmake... yes
 -- /usr/bin/gmake -f Makefile.embed
checking for main() in -lgit2_embed... yes
checking for git2.h... yes
creating Makefile
make "DESTDIR="
gcc -I. 
-I/builddir/build/BUILD/rugged-0.19.0/usr/share/gems/gems/rugged-0.19.0/ext/rugged/../../vendor/libgit2/include
-I/usr/include -I/usr/include/ruby/backward -I/usr/include -I. -DHAVE_GIT2_H   
-fPIC -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64
-mtune=generic  -g -Wall -m64 -o rugged.o -c rugged.c

...

gcc -shared -o rugged.so rugged.o rugged_blob.o rugged_branch.o rugged_commit.o
rugged_config.o rugged_diff.o rugged_diff_delta.o rugged_diff_hunk.o
rugged_diff_line.o rugged_diff_patch.o rugged_index.o rugged_note.o
rugged_object.o rugged_reference.o rugged_remote.o rugged_repo.o
rugged_revwalk.o rugged_settings.o rugged_signature.o rugged_tag.o
rugged_tree.o -L. -L/usr/lib64 -L. -Wl,-z,relro -fstack-protector -rdynamic
-Wl,-export-dynamic
-L/builddir/build/BUILD/rugged-0.19.0/usr/share/gems/gems/rugged-0.19.0/ext/rugged
  -m64  -lruby -lgit2_embed  -lpthread -lrt -ldl -lcrypt -lm   -lc

...

Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <=
4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit)
libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit)
libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit)
libc.so.6(GLIBC_2.8)(64bit) libcrypt.so.1()(64bit) libdl.so.2()(64bit)
libm.so.6()(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit)
librt.so.1()(64bit) libruby.so.2.0()(64bit) rtld(GNU_HASH)



You should probably specify LIBGIT2_PATH [1] to make it build against system
libgit2. And I still believe it is good idea to remove the vendor dir in %prep
section, which would make the build fail, instead of silently used the vendored
libgit2.


[1]
https://github.com/libgit2/rugged/blob/development/ext/rugged/extconf.rb#L28

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=emwN8UM6Ft&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]