[Bug 989266] Review Request: smooks - Smooks Framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=989266



--- Comment #8 from Gerard Ryan <gerard@xxxxxxx> ---
(In reply to gil cattaneo from comment #7)
> there is also a bundled library
> commons/src/main/java/org/milyn/annotation
> commons/src/main/java/org/milyn/annotation/fusionsoft-license.txt 
> is a modified version of the original Fusionsoft Annotation
> http://www.fusionsoft-online.com/articles-java-annotations.php

Solved: I've updated to remove that in %prep, and not build any of the
subpackages that use it. I don't need any of them right now, and if anyone does
in the future, then I'd rather see if that library can be factored out of the
upstream project altogether, than create a package for it, since it seems like
a dead project, and I use the term 'project' loosely here.

(In reply to gil cattaneo from comment #5)
> Issues:
> =======
> [!]: License field in the package spec file matches the actual license.
>      Note: Checking patched sources after %prep for licenses. Licenses found:
>      "Apache (v2.0)", "LGPL (v2.1))", "Unknown or generated". 156 files have
>      unknown license.
> 
> - [!]: Package does not include license text files separate from
> upstream.
> 
> Should query upstream to have it included.
> and temporarily install http://www.apache.org/licenses/LICENSE-2.0.txt

I've added ASL 2.0 to the License field, and am now installing the license
text. I will propose the license text into the upstream project as a pull
request.

> - Package installs properly.
>   Note: Installation errors (see attachment)
>   See: https://fedoraproject.org/wiki/Packaging:Guidelines

This seems to be a problem with hsqldb1 in rawhide (or maybe maven or something
else). I think it should resolve it the way it is, and it does resolve it fine
in f19.

Thanks for reviewing!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Y9qRBXU1Q1&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]