Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ntop - A network traffic probe similar to the UNIX top command Alias: ntop https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219025 ------- Additional Comments From bjohnson@xxxxxxxxxxxx 2007-03-16 13:21 EST ------- (In reply to comment #77) > seems to patch the same file one after another. And moreover > those patches seems to be unuseful since you overwrite the file? I've integrated this into one sane patch now :) > I suggest using the 'official scriptlets' found here: > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets > Yours don't seem wrong, it is for consistency. Using > /sbin/service may be more robust over time, however. > It adds a > Requires(preun): /sbin/service My original intent was to avoid the dependency, although I later found that my init file uses the daemon function that requires initscripts package anyway, so now there is no reason to not use /sbin/service. Fixed. I also updated the scriptlents to make them look more like the ScriptlnetSnippets. > Build log looks saner, but there is still a duplication of the > CFLAGS. In my opinion it comes from Makefile.am, the following > line should be removed (at least @CFLAGS@ should be removed): > > AM_CFLAGS = @CFLAGS@ I added this fix, but can you explain to me more what the intention is? I would like to document why this has to be changed. > In the init file, maybe add the LSB bits? (within BEGIN INIT INFO) Added. > still in the init file the summary is a bit terse. Updated this to match the summary from the spec file. (In reply to comment #78) > Created an attachment (id=149782) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=149782&action=view) [edit] > fix enable-mysql handling > > The handling of --enable-mysql is broken, should be > fixed with that patch (for upstream). Integrated and forwarded to upstream. This does now correctly generate a dependency for me. (In reply to comment #80) > Also there are no logs in the file specified in the logrotate > config file. The logs go through syslog for me. Is it normal, > or is there something wrong? Remnants of times passed when I was having it lot to a regular log file. I removed all remnants of the logrotate pieces. Spec URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/ntop.spec SRPM URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/ntop-3.3-0.9.20070314cvs.fc6.src.rpm * Fri Mar 16 2007 Bernard Johnson <bjohnson@xxxxxxxxxxxx> - 3.3-0.9.20070314cvs - update to 20070314cvs - add additional mysql patch from Patrice - remove all of unused logrotate pieces - use /sbin/service to start/stop services - update scriptlets to be easier to read - Better description to initfile summary - add LSB bits to initfile -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review