https://bugzilla.redhat.com/show_bug.cgi?id=979666 --- Comment #13 from Petr Šabata <psabata@xxxxxxxxxx> --- You haven't look at the code at all, have you? As usually, items marked as FIX are needed for the review; TODO are (strongly) recommended. TODO: BR perl (called in spec) TODO: Run-require perl(B) FIX: BR perl(base) FIX: BR perl(Carp) FIX: BR perl(CGI) TODO: BR perl(Config) FIX: BR perl(constant) FIX: BR perl(Cwd) FIX: BR perl(Data::Dumper) FIX: Run-require perl(Data::Dumper) FIX: BR perl(Devel::StackTrace) FIX: BR perl(Digest::MD5) FIX: Run-require perl(Digest::MD5) FIX: BR perl(Encode) FIX: Run-require perl(Encode) FIX: BR perl(Exporter) FIX: BR perl(ExtUtils::MM_Unix) FIX: BR perl(Fatal) TODO: BR perl(Fcntl) TODO: BR perl(File::Basename) TODO: BR perl(File::Copy) TODO: BR perl(File::Find) FIX: BR perl(File::Path) FIX: Run-require perl(File::Path) FIX: BR perl(File::Spec) TODO: BR perl(File::stat) TODO: BR perl(FindBin) FIX: BR perl(Getopt::Long) TODO: BR perl(if) FIX: BR perl(lib) FIX: BR perl(List::Util) FIX: BR perl(Mouse::Role) FIX: BR perl(Mouse::Util::TypeConstraints) TODO: BR perl(overload) FIX: BR perl(Plack::Builder) FIX: BR perl(Plack::Response) FIX: BR perl(Plack::Test) TODO: BR perl(SelectSaver) TODO: BR perl(strict) FIX: BR perl(threads) TODO: BR perl(Tie::Array) TODO: BR perl(Tie::Hash) TODO: BR perl(Time::localtime) TODO: BR perl(utf8) TODO: BR perl(vars) TODO: BR perl(warnings) FIX: BR perl(XSLoader) FIX: Run-equire perl(XSLoader) Some of those are used in optional tests (such as Plack::*) but given your current dependency list, it seems like you wanted to run those therefore I've included them too. TODO: Package the 'example' directory as documentation. There's a lot of useful stuff there. TIP: Since you define the %pkgname macro, you could also use it in URL (or possibly even Name). TODO: Remove the perl(autodie) BR. You need the Fatal module, so just BR that (mentioned boave). The rest of the package is okay. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=V4us3P3E4m&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review