https://bugzilla.redhat.com/show_bug.cgi?id=989859 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@xxxxxxxxxx --- Comment #5 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- (In reply to Christopher Meng from comment #4) > (In reply to Volker Fröhlich from comment #3) > > https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses -- > > The license should read "BSD" in the spec file. > > Fixed. > > > The example program is not part of the main package. Why are you shipping it? If it's just an example, it should not be shipped as "*-util". If it's an utility, then packaging would make sense. Besides this, due to its small side I'd recommend to put the xls2csv into the main package instead of putting it into a "*-util" subpackage. > > Can you run the tests? > > No rules for test, can you ensure? The rules are there ("make check"), it's just that this package is broken. > > The xls2csv binary causes my build to break with an rpath issue. During builds, binaries being linked against just having been built shared-libs occasionally require an explicit LD_LIBRARY_PATH=<path to *.so in builddir> being set. e.g. something along the lines of make check LD_LIBRARY_PATH="$(pwd)/<somewhere>" could be neccessary. Another common issue in such situations is config-files not being found, because they are not installed, yet. I haven't tried to check what may apply here. > I build the library without any problem, not sure about yours, any logs? I guess you have your package already installed and are not building in a clean environment. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yYhn5cRwT2&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review