https://bugzilla.redhat.com/show_bug.cgi?id=988545 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@xxxxxxxxxx --- Comment #11 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- Some remarks: 1. The package is incomplete or lacks a dep: stout/gtest.hpp accesses a file, which does not exist: include/stout/gtest.hpp:#include <gtest/gtest.h> 2. C++-header-only packages should exercise test suites, when a package provides such. This package provides a testsuite (examples), unfortunately these are nonbuildable. 3. The cpp-define usage of this package raises doubts on this package's code quality: E.g. a) Some header guards are non-"package"-prefixed: __NOTHING_HPP__ include/stout/nothing.hpp __PROCESS_PREPROCESSOR_HPP__ include/stout/preprocessor.hpp __PROC_HPP__ include/stout/proc.hpp All other header-guards are package-prefixed (They use: "__STOUT_"*) b) Some of the defines being used are likely to clash with other defines, e.g. CAT, REPEAT etc. in include/stout/preprocessor.hpp c) The package relies on autoconf defines in external headers: include/stout/gzip.hpp:#ifdef HAVE_LIBZ include/stout/net.hpp:#ifdef HAVE_LIBCURL This violates the autoconf working principles and needs to be fixed (REVIEW BLOCKER) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=86yQd7lalI&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review