[Bug 989752] Review Request: SDL2 - A cross-platform multimedia library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=989752

--- Comment #5 from Peter Lemenkov <lemenkov@xxxxxxxxx> ---
(In reply to Igor Gnatenko from comment #4)
> (In reply to Peter Lemenkov from comment #3)
> > * I see you enabled static subpackage. Could you please elaborate a
> > technical rationale behind this?
> No. SDL1 use it.

That's not a valid reason. So please remove it since we shouldn't encourage
static libraries usage and even packaging.

> > * Could you please just remove aRts, Esound, NAS support entirely? Less
> > outdated featured your package has, less bugs it contains.
> this only for rhel

That's not an explanation either. Please disable it. Also you enabled it
wrongly so I'm assuming that you didn't test it. That's a bad sign - a
maintainer enables things which he doesn't even tests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cxXjAxjERz&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]