[Bug 970407] Review Request: mingw-libtheora - Theora Video Compression Codec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=970407

Veaceslav Mindru <mindruv@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mindruv@xxxxxxxxx

--- Comment #1 from Veaceslav Mindru <mindruv@xxxxxxxxx> ---
Hello Steve,

Spec looks good, rpmlint dose not report E/W. just some small modifications
needed. 

remove rm -rf $RPM_BUILD_ROOT it's not required any more in EPEL6

>%install
>rm -rf $RPM_BUILD_ROOT


same story here 

>%clean
>rm -rf $RPM_BUILD_ROOT


http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean

The %clean section is not required for F-13 and above. Each package for F-12
and below (or EPEL 5) MUST have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2xk6VKalBO&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]