https://bugzilla.redhat.com/show_bug.cgi?id=985446 Veaceslav Mindru <mindruv@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mindruv@xxxxxxxxx --- Comment #3 from Veaceslav Mindru <mindruv@xxxxxxxxx> --- Hello David , I think this should be corrected. >Source0: gtk-vim-syntax-20130716.tar.gz http://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overview Source0: The full URL for the compressed archive containing the (original) pristine source code, as upstream released it. "Source" is synonymous with "Source0". If you give a full URL (and you should), its basename will be used when looking in the SOURCES directory. If possible, embed %{name} and %{version}, so that changes to either will go to the right place. Preserve timestamps when downloading source files. If there is more than one source, name them Source1, Source2 and so on. If you're adding whole new files in addition to the pristine sources, list them as sources after the pristine sources. A copy of each of these sources will be included in any SRPM you create, unless you specifically direct otherwise. See Source URL for more information on special cases (e.g. revision control). I still can see errors reported by rpmlint [mindruv@localhost tmp]$ rpmlint gtk-vim-syntax.spec gtk-vim-syntax.spec:15: W: non-standard-group Application/Editors gtk-vim-syntax.spec: W: no-%build-section gtk-vim-syntax.spec: W: invalid-url Source0: gtk-vim-syntax-20130716.tar.gz 0 packages and 1 specfiles checked; 0 errors, 3 warnings. [mindruv@localhost tmp]$ >#URL: http://physics.muni.cz/~yeti/vim/ I would also recommend to drop comments if not carrying vital information. As this is waste of bytes. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wPJj4510gp&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review