[Bug 961375] Review Request: rubygem-thread_safe - Thread-safe collections and utilities for Ruby

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=961375

--- Comment #4 from Axilleas Pipinellis <axilleas@xxxxxxxxxxxx> ---
Hi Josef,

This is good to go when you fix two minor issues.

- non-executable-script Rakefile 0644L /usr/bin/env
  Removing the shebang seems fine to me.

- Use macros where possible
  When removing the jar file I would replace the hardcoded directory with
%{buildroot}/%{gem_libdir}/%{gem_name}/jruby_cache_backend.jar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=840fqzm58L&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]