https://bugzilla.redhat.com/show_bug.cgi?id=989265 --- Comment #5 from Gerard Ryan <gerard@xxxxxxx> --- Thanks for the review gil! All issues found have been fixed: https://github.com/grdryn/dtdparser-rpm/commit/7970922a731f320e296aa62fc25fad507c85866f (In reply to gil cattaneo from comment #4) > found source code also here > http://sourceforge.net/projects/dtdparser/files/dtdparser/1.21/dtdparser-1. > 21.tgz > regards Thanks, using that one now. (In reply to gil cattaneo from comment #3) > Issues: > please install also ASL_LICENSE Done. > please fix incorrect-fsf-addres > with > sed -i "s,59 Temple Place,51 Franklin Street,;s,Suite 330,Fifth > Floor,;s,02111-1307,02110-1301," LICENSE Done. > remove jpackage-utils references fron javadoc subpackage Done. > please fix zero-length /usr/share/javadoc/dtdparser/package-list Done. > somethings wrong happen here > find -name \*.jar -o -name \*.class -delete > - Bundled jar/class files should be removed before build > Note: Jar files in source (see attachment) > See: > http://fedoraproject.org/wiki/Packaging:Java#Pre-built_JAR_files_. > 2F_Other_bundled_software' Done -- was missing the first -delete. (In reply to gil cattaneo from comment #2) > Issues: > ======= > - Package do not use a name that already exist > Note: A package already exist with this name, please check > https://admin.fedoraproject.org/pkgdb/acls/name/dtdparser > See: > https://fedoraproject.org/wiki/Packaging/ > NamingGuidelines#Conflicting_Package_Names As mentioned in comment #1, this was a retired package that I'm bringing back, hence the existing record. Thanks again! :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=R3JIf3T8WW&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review