https://bugzilla.redhat.com/show_bug.cgi?id=982285 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxxxxx --- Comment #8 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- Small comment about the php sub-package Please remove Requires: php You obviously don't need "mod_php" and "httpd" (ABI requirement are enough) You can also remove %global php_extdir ... This macro is defined on fedora and rhel-6 (only required on rhel-5, which doesn't seems to be targeted) What is the {php_extdir}/Thrift/ dir used for ? I also prefer to have the subpackage dependencies in the subpackage definition. (ex BR: php-devel). It will also save you some conditional stuf for some language (erlang, ruby) as the sub-package definition already have this condition. Just make spec a little more legible. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TYz9l2Jqzm&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review