[Bug 804125] Review Request: rdkit - A toolkit for cheminformatics and machine learning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=804125

--- Comment #14 from Christopher Meng <cickumqt@xxxxxxxxx> ---
Hi,

First, becasue F20 will use unversioned docdir name, in your global field you
should modify

%global docdir      %{_docdir}/%{name}-%{version}

Also %{docdir}/README should be changed to %{_pkgdocdir}/README

Then, cmake has %cmake macro, you should rpm -E %cmake and find if the macro
can replace 6 lines of options.

Next, Remove rm -rf %{buildroot} in %install

Last, are these %{_libdir}/*.cmake needed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9dY9ko20lE&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]