https://bugzilla.redhat.com/show_bug.cgi?id=870853 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@xxxxxxxxx --- Comment #5 from Christopher Meng <cickumqt@xxxxxxxxx> --- I'll take an informal review. 1. Why not nameing it safehaven but haven? 2. %define _hardened_build 1 should be %global _hardened_build 1 3. Can you ask upstream to avoid using %global _configure ../../configure mkdir -p build/standard build/gtkgui build/full cd build/standard %configure --disable-ext2fs --disable-gmime --without-postgresql? I think this is not cmake, why should we burden ourselves? 4. I think you should add requires of main package for all subpackages. 5. Once you've done the 4, you should remove subpackages' %doc README COPYING As these doc should only present one time in main package. 6. You shouldn't create a new tarball when the download URL is available. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vhr5TKL1HQ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review